Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-85525: Indicate supported sound header formats #21575

Merged
merged 4 commits into from
Oct 15, 2022
Merged

gh-85525: Indicate supported sound header formats #21575

merged 4 commits into from
Oct 15, 2022

Conversation

nanjekyejoannah
Copy link
Contributor

@nanjekyejoannah nanjekyejoannah commented Jul 21, 2020 •
edited by bedevere-bot
Loading

merwok
merwok reviewed Jul 24, 2020
View reviewed changes
Doc/library/sndhdr.rst Show resolved Hide resolved
Doc/library/sndhdr.rst Show resolved Hide resolved
@nanjekyejoannah nanjekyejoannah mentioned this pull request Apr 11, 2022
Closed
@hugovk
Copy link
Member

hugovk commented Apr 11, 2022

Note the sndhdr module is deprecated in 3.11 and set for removal in 3.13.

See PEP 594 – Removing dead batteries from the standard library and #91217.

@AlexWaygood
Copy link
Member

Note the sndhdr module is deprecated in 3.11 and set for removal in 3.13.

See PEP 594 – Removing dead batteries from the standard library and #91217.

Nonetheless, this does look like a relatively simple docs enhancement that would be quite nice to have. It would be nice if it could get over the line.

@JelleZijlstra JelleZijlstra self-requested a review April 12, 2022 13:49
@JelleZijlstra JelleZijlstra changed the title bpo-41353: Indicate supported sound header formats gh-85525: Indicate supported sound header formats Apr 12, 2022
@JelleZijlstra JelleZijlstra removed their request for review April 13, 2022 02:56
@nanjekyejoannah
Copy link
Contributor Author

nanjekyejoannah commented Apr 13, 2022 •
edited
Loading

@willingc can you help review this and see if it can be merged?

hugovk
hugovk reviewed Apr 13, 2022
View reviewed changes
Doc/library/sndhdr.rst Show resolved Hide resolved
Doc/library/sndhdr.rst Outdated Show resolved Hide resolved
@AA-Turner AA-Turner added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes docs Documentation in the Doc dir and removed CLA signed labels Jun 7, 2022
@AA-Turner
Copy link
Member

I agree with @AlexWaygood that this would be useful to consumers of the module for 3.10 through 3.12 -- I've no comments beyond Hugo's points though.

A

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jul 30, 2022
@nanjekyejoannah nanjekyejoannah merged commit 05c042e into python:main Oct 15, 2022
@miss-islington
Copy link
Contributor

Thanks @nanjekyejoannah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @nanjekyejoannah, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 05c042e70786bd2e3fcb274d185e1e0a54dab5a7 3.11

@miss-islington
Copy link
Contributor

Sorry, @nanjekyejoannah, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 05c042e70786bd2e3fcb274d185e1e0a54dab5a7 3.10

@AlexWaygood AlexWaygood removed the needs backport to 3.11 only security fixes label Oct 15, 2022
@AlexWaygood AlexWaygood added the needs backport to 3.11 only security fixes label Oct 15, 2022
@miss-islington
Copy link
Contributor

Thanks @nanjekyejoannah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @nanjekyejoannah, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 05c042e70786bd2e3fcb274d185e1e0a54dab5a7 3.11

@AlexWaygood AlexWaygood added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Oct 15, 2022
@miss-islington
Copy link
Contributor

Thanks @nanjekyejoannah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 15, 2022
@nanjekyejoannah @miss-islington
pythongh-85525: Indicate supported sound header formats (pythonGH-21575)
26f058c 
* Indicate supported sound header formats

* modify file names

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 05c042e)

Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
@bedevere-bot
Copy link

GH-98277 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 15, 2022
miss-islington added a commit that referenced this pull request Oct 15, 2022
@miss-islington @nanjekyejoannah
gh-85525: Indicate supported sound header formats (GH-21575)
232a988 
* Indicate supported sound header formats

* modify file names

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 05c042e)

Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merwok merwok merwok left review comments

@hugovk hugovk hugovk left review comments

Assignees

@nanjekyejoannah nanjekyejoannah

Labels
docs Documentation in the Doc dir needs backport to 3.10 only security fixes skip news stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@nanjekyejoannah @hugovk @AlexWaygood @AA-Turner @miss-islington @bedevere-bot @merwok @the-knights-who-say-ni @JelleZijlstra